Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-13525 show one test gateway account for degatewayed users #4486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PP-13525 show one test gateway account for degatewayed users #4486

wants to merge 1 commit into from

Conversation

nlsteers
Copy link
Collaborator

@nlsteers nlsteers commented Feb 26, 2025 •
edited
Loading

WHAT

  • update my-services controller to enable conditional filtering of test gateway accounts when user is opted into degateway
  • simplify my services styles and views
  • remove reference to service-switcher now that accounts are presented as links, not forms
  • link to simplified settings for manage team, organisation details and service name settings
    • dynamically load the correct account type for these links depending on the go live status of the service
  • update routes and paths
  • remove unnecessary call to connector when determining if the service is a Worldpay test service in the dashboard activity controller
  • remove old ui tests, prefer cypress and mocha
  • fix issue where account and service resolution middleware would throw an error when adminusers and connector disagree about which gateway account should be returned for a service
    • the middleware now logs a warning when there is a mismatch between connector and adminusers, we prefer connector as the source of truth in this situation

SCREENS

NOT DEGATEWAYED

Screenshot 2025-02-28 at 19 06 15 Screenshot 2025-02-28 at 19 06 10

DEGATEWAYED

Screenshot 2025-02-28 at 19 06 23 Screenshot 2025-02-28 at 19 05 54

@nlsteers nlsteers force-pushed the pp-13525/show_one_test_gateway_account_only branch 2 times, most recently from d9b7b25 to ae19df0 Compare February 28, 2025 17:59
@nlsteers nlsteers changed the title [WIP] PP-13525 show one test gateway account only PP-13525 show one test gateway account for degatewayed users Feb 28, 2025
@nlsteers nlsteers marked this pull request as ready for review February 28, 2025 18:00
@nlsteers
PP-13525 show only one test account for degatewayed users
2b8d2c7 
- update `my-services` controller to enable conditional filtering of test gateway accounts when user is opted into degateway
- simplify `my services` styles and views
- remove reference to `service-switcher` now that accounts are presented as links, not forms
- update routes and paths
- remove unnecessary call to connector when determining if the service is a Worldpay test service in the `dashboard activity` controller
- remove old `ui` tests, prefer cypress and mocha
- fix issue where account and service resolution middleware would throw an error when adminusers and connector disagree about which gateway account should be returned for a service
  - the middleware now logs a warning when there is a mismatch between connector and adminusers, we prefer connector as the source of truth in this situation
@nlsteers nlsteers force-pushed the pp-13525/show_one_test_gateway_account_only branch from ae19df0 to 2b8d2c7 Compare February 28, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nlsteers