Fix flakey test due to Javascript animation timing #2561
+18
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test fails intermittently with the error: ``` Capybara::ElementNotFound: Unable to find visible css ".action-content-block-update" within #<Capybara::Node::Element tag="div" path="/HTML/BODY[1]/SECTION[1]/MAIN[1]/DIV[1]/DIV[2]/DIV[1]/DIV[4]/DIV[1]/DIV[3]/DIV[2]/DIV[3]"> ``` This seems to be because the expanding of the edition panel is not always completing before the check for the "content block update" element occurs. Adding the extra `within` selector for the `.collapse.in` classes to be present (which happens once the "expand" animation has completed) appears to at least make the test more reliable (I can't really be 100% sure it's completely resolved, but I've run the test dozens of times locally now without failure).
syed-ali-tw
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fails intermittently with the error:
This seems to be because the expanding of the edition panel is not always completing before the check for the "content block update" element occurs. Adding the extra
withinselector for the.collapse.inclasses to be present (which happens once the "expand" animation has completed) appears to at least make the test more reliable (I can't really be 100% sure it's completely resolved, but I've run the test dozens of times locally now without failure).