[ON-HOLD] Fix for inaccurate holiday entitlement calculations #6690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Due to the inaccuracies introduced by the "months_worked" method, we have decided to calculate the "fraction_of_year" using "days_worked" instead. This avoids the need for rounding. - The new "edge cases" test added to the test file, is based on user feedback, where an example scenario producing incorrect results is given:[Feedback](https://support.publishing.service.gov.uk/anonymous_feedback?document_type=&from=31+Jan+2024&organisation=&paths=1726b70c5b9bacb0538b&to=31+Jan+2024) - The change made to the calculator successfully passes the new "edge cases" test, as well as 175 other tests. However, there are 46 tests that are currently failing. - We are waiting for content designers to confirm with the department if the expected assertions, for the failing tests, are correct. We believe the data used for the assertions in the failing tests, are inaccurate and will need to be changed. - As we wait for this feedback from the content designers, we will leave these tests failing. - P.S: some parts of the tests are commented out because they are testing the implementation of the calculator as opposed to testing behaviour, which is not BDD-friendly and makes refactoring difficult.
cynthia-anya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the inaccuracies introduced by the "months_worked" method, we have decided to calculate the "fraction_of_year" using "days_worked" instead. This avoids the need for rounding.
The new "edge cases" test added to the test file, is based on user feedback, where an example scenario producing incorrect results is given:Feedback
The change made to the calculator successfully passes the new "edge cases" test, as well as 175 other tests. However, there are 46 tests that are currently failing.
We are waiting for content designers to confirm with the department if the expected assertions, for the failing tests, are correct. We believe the data used for the assertions in the failing tests, are inaccurate and will need to be changed.
As we wait for this feedback from the content designers, we will leave these tests failing.
P.S: some parts of the tests are commented out because they are testing the implementation of the calculator as opposed to testing behaviour, which is not BDD-friendly and makes refactoring difficult.
Trello card