Make unpublishing operation asynchronous #9870
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDSNewt
force-pushed
the
make-unpublishing-async
branch
4 times, most recently
from
d974741 to
8cc90ea
Compare
We'll be calling this in the next commit.
Whitehall and Publishing API don't always agree on what a valid redirect URL looks like. Consequently, unpublishing might appear to succeed in Whitehall but be rejected downstream by Publishing API. This caused a support ticket recently: https://govuk.zendesk.com/agent/tickets/6016851 Switching the unpublish technique to synchronous means that any 4xx/5xx errors from Publishing API will be caught on submission, meaning Whitehall will catch the error and display it to the user, and roll back any Whitehall state changes. See https://github.com/alphagov/whitehall/blob/7c5f793c56fc47e4bd6aa07839885d4387fc9b2b/app/services/edition_service.rb#L13-L17 Trello: https://trello.com/c/xlvNUI3c/3382-make-whitehalls-unpublishing-call-to-publishing-api-synchronous
GDSNewt
force-pushed
the
make-unpublishing-async
branch
from
8cc90ea to
4ae8543
Compare
ryanb-gds
requested changes
Feb 7, 2025
| @@ -188,6 +189,20 @@ def assert_sets_redirect_url_in_asset_manager_to(redirect_url) | |||
| end | |||
|
|
|||
| def assert_redirected_in_publishing_api(content_id, redirect_path) | |||
There was a problem hiding this comment.
This method is wrongly named I think, should be assert_gone_in_publishing_api?
| when "withdraw" | ||
| edition.translations.each do |translation| | ||
| api.publish_withdrawal_async( | ||
| api.publish_withdrawal_sync( |
There was a problem hiding this comment.
I wonder how many editions there are with lots of translations... could get sloooow. Might be worth checking integration to see if this is acceptable (i.e. if only a few editions have say > 2 translations we can probably live with it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ‘unpublish’ action in Whitehall currently creates a worker to call Publishing API asynchronously. It should be updated to call Publishing API synchronously.
We should then listen for the response from Publishing API, and should catch any 4xx error and avoid updating the state of the document in Whitehall, and display an error message to the user.
Trello: https://trello.com/c/xlvNUI3c/3382-make-whitehalls-unpublishing-call-to-publishing-api-synchronous
Follow these steps if you are doing a Rails upgrade.