Jose dale branch #17
Jose dale branch #17
Conversation
|
Please update your branch to sync the latest changes from main. |
| @@ -0,0 +1,123 @@ | |||
| package main | |||
There was a problem hiding this comment.
If possible please reuse the one in our testclient.go and add your entry there.
test-client/client
Outdated
There was a problem hiding this comment.
Please try not to commit binaries.
There was a problem hiding this comment.
Please don't create another server, we have already a server on main.go
server/server
Outdated
There was a problem hiding this comment.
Please try not to commit a binary.
There was a problem hiding this comment.
good morning sir, we would like to retract this pull request, sorry for the inconvenience
testclient/testclient.go
Outdated
There was a problem hiding this comment.
Use this testclient for testing purposes.
| grpcServer := grpc.NewServer() | ||
|
|
||
| // Register the TopicService | ||
| topicService := &topic.TopicService{SpannerClient: client} |
There was a problem hiding this comment.
Please don't create another service.
| "context" | ||
| "log" | ||
| "net" | ||
| topic "tidy/crud-topic" |
There was a problem hiding this comment.
Please check import tidy/crud-topic not sure whether this the correct way.
crud-topic/subscription_beta.go
Outdated
There was a problem hiding this comment.
Is this the gRPC handlers? if so, please move this to our server.go
crud-topic/topic.go
Outdated
There was a problem hiding this comment.
Same on the file above, please move this to server.go
crud-topic/subscription_beta.go
Outdated
|
|
||
| stmt := spanner.Statement{ | ||
| SQL: "INSERT INTO Subscriptions (subscriptionID, TopciID) VALUES (@id, @topic_id)", | ||
| Params: map[string]interface{}{"subscriptionID": req.id, "TopicID": *&req.TopicId}, |
There was a problem hiding this comment.
You can use spanner.Insert, please check other codes for reference.
crud-topic/subscription_beta.go
Outdated
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Please check empty spaces.
|
Noted everything sir. Will do first thing tommorow. Thanks |
…phauslabs/pubsub into jose-dale_branch
modified proto