Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 51: Refactor ALCF tomography reconstruction flows #52

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

davramov
Copy link
Contributor

This pull request addresses issue #51: Refactor ALCF tomography reconstruction flows

  • Refactored ALCF tomography implementation to use job_controller and transfer_controller methods.
  • Updated pytest script to reflect these changes.
  • Minor update to get_controller method in job_controller.py to ensure config is passed into the ALCFTomographyHPCController when it is selected

I tested these changes locally on the NIST sand dataset, and all of the steps appear to work properly. The alcf_recon_flow may require redeployment on flow-prd (the Prefect server) to reflect these changes.

…ransfer_controller methods. Updated pytest to reflect these changes.
@davramov
Copy link
Contributor Author

davramov commented Feb 4, 2025

Here is a preview of the MkDocs wiki I am putting together for this repo: https://davramov.github.io/splash_flows_globus/

I will look into adding the mkdocs build command into the github actions so it can be added with this PR. This command creates and updates a new branch called gh-pages which would host the wiki as a github page at https://als-computing.github.io/splash_flows_globus/

@dylanmcreynolds dylanmcreynolds merged commit fce3d0c into als-computing:main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants