ensure that % is escaped during percent encoding #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the % sign is used for the escape in percent encoding, we need to ensure that that is itself escaped if found in the input. Debian git tags in vcs_urls in particular seem to be moving to replacing the : in a version like `1:41.1` into `1%41.1`. The correct encoding of that winds up being `1%2541.1`. Without this, adding the vcs_url as it is given will wind up forcing the _parsing_ of the subsequent displayed PackageUrl to decode the `1%41.1` as `1A.1`. Fixes althonos#12.
ctron
approved these changes
Aug 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
=========================================
Coverage ? 86.15%
=========================================
Files ? 7
Lines ? 260
Branches ? 0
=========================================
Hits ? 224
Misses ? 36
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for the PR. It's released as |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the % sign is used for the escape in percent encoding, we need to ensure that that is itself escaped if found in the input. Debian git tags in vcs_urls in particular seem to be moving to replacing the : in a version like
1:41.1into1%41.1. The correct encoding of that winds up being1%2541.1. Without this, adding the vcs_url as it is given will wind up forcing the parsing of the subsequent displayed PackageUrl to decode the1%41.1as1A.1.Fixes #12.