Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolved warnings false detection in ColorScheme definition #73

Merged

Conversation

boywithdv
Copy link
Contributor

@boywithdv boywithdv commented Nov 1, 2024

🔗 Related Issues

🙌 What's Done

  • Resolving the bug that warnings are also displayed in colorScheme definitions.

✍️ What's Not Done

🖼️ Image Differences

Before After
image image

🤼 Desired Review Method

  • Correction Commit
  • Pair programming

Note

It is possible that a reviewer's will may cause a method to be implemented that is not selected.

📝 Additional Notes

Pre-launch Checklist

  • I have reviewed my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I updated/added relevant documentation (doc comments with ///).

@boywithdv boywithdv changed the title fix: warnings-false-detection-in-ColorScheme-definition fix: Resolved warnings false detection in ColorScheme definition Nov 1, 2024
@boywithdv boywithdv marked this pull request as ready for review November 1, 2024 07:26
@boywithdv boywithdv requested a review from a team as a code owner November 1, 2024 07:26
@boywithdv boywithdv requested review from k-nkmr and removed request for a team November 1, 2024 07:26
@boywithdv boywithdv requested a review from k-nkmr November 5, 2024 03:22
Copy link
Contributor

@k-nkmr k-nkmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boywithdv boywithdv merged commit 4dc4b4e into main Nov 5, 2024
1 check passed
@boywithdv boywithdv deleted the 65-avoid-hardcoded-detection-in-colorscheme-definition branch November 5, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid_hardcoded_color warnings false detection in ColorScheme definition
2 participants