Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing VirtualEntity and VirtualEntityGroup static methods #300

Closed
wants to merge 5 commits into from
Closed

Add missing VirtualEntity and VirtualEntityGroup static methods #300

wants to merge 5 commits into from

Conversation

xLuxy
Copy link
Contributor

@xLuxy xLuxy commented Sep 3, 2023 •
edited
Loading

  • added missing VirtualEntity.getByID and VirtualEntity.getByRemoteID
  • added missing VirtualEntityGroup.getByID and VirtualEntityGroup.getByRemoteID

NOTE: getByRemoteID currently return NULL for both - for VirtualEntity it will be fixed in core.

// Edit: Commented out VirtualEntityGroup.getByRemoteID because the client is currently not aware of remote groups.

Yiin
Yiin approved these changes Sep 4, 2023
View reviewed changes
Copy link

@Yiin Yiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xLuxy xLuxy closed this Sep 30, 2023
@xLuxy xLuxy deleted the fixes/virtual-entity-static-methods branch September 30, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yiin Yiin Yiin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xLuxy @Yiin