Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALTV-426 Add Interior class #106

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

ALTV-426 Add Interior class #106

wants to merge 8 commits into from

Conversation

Doxoh
Copy link
Contributor

@Doxoh Doxoh commented Sep 30, 2024

No description provided.

@Doxoh Doxoh marked this pull request as ready for review October 4, 2024 18:47
virtual uint16_t GetRoomCount() const = 0;
virtual uint16_t GetPortalCount() const = 0;
virtual alt::Position GetPosition() const = 0;
virtual alt::Position GetRotation() const = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alt::Position?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

virtual ~IInterior() = default;

public:
struct ExtentInfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename this struct to AABB (Axis-aligned bounding box) and move to some shared file ie (types/AABB.h)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants