Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding properties for title & corner radius and a bug fix for no title/no arrow #59

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

macelangelo
Copy link

Here's what's in my changes:

  1. FR - Adding support to adjust corner radius - We wanted a popover with a zero corner radius, but now it's a property that can be set. The default value is 10.0 as before.
  2. Kind of a bug/documentation issue - The docs show you can hide the title by setting the title on FPPopover to nil. The problem is that FPPopoverController title is not directly tied to the FPPopoverView title, which is what the code ultimately looks at. The current code looks at the title of the view controller you pass in initWithViewControlller, so the workaround is to set your view controller title to nil before initing FPPopover. Get and Set title will return the value from FPPopoverView.
  3. Related to 2 - There's a bug in setupViews method of FPPopoverView when you have both no arrow and no title. The code still adds space for a title view. This has been fixed.

I tested the changes with the demo project and everything looked okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant