Lazy loaded _window & _parentView to fix the chicken and egg problem with coordanites #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're going to check the device orientation make use of the translation. This fixes a few rotation issues. "need to move up?" now takes into account the incoming origin of presentation and the exclusion of old_y when negative prevent the pop over going cookie monster on it's initial height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're going to check the device orientation make use of the translation. This fixes a few rotation issues.
"need to move up?" now takes into account the incoming origin of presentation and the exclusion of old_y when negative prevent the pop over from going cookie monster on it's initial height.