Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump replay orchestrator launcher #310

Merged
merged 3 commits into from
Aug 14, 2023
Merged

bump replay orchestrator launcher #310

merged 3 commits into from
Aug 14, 2023

Conversation

dbook13
Copy link
Contributor

@dbook13 dbook13 commented Aug 11, 2023

Patch includes timeout on S3 download file call which should prevent replays from hanging.

@dbook13 dbook13 requested a review from a team August 11, 2023 12:55
@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
report-diffs-action ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 1:12pm

@github-actions
Copy link

github-actions bot commented Aug 11, 2023

🤖 Meticulous replayed 1 user sessions and took 8 screenshots. Meticulous did not run on main of the main branch and so there was nothing to compare against.

Please merge your pull request for setting up Meticulous in CI and ensure that it’s running on push events to the main branch.

Test suite: test Meticulous with deployment url. Last updated for commit 8c50e28. This comment will update as new commits are pushed.

@github-actions
Copy link

github-actions bot commented Aug 11, 2023

✅ Meticulous spotted zero visual differences across 8 screens tested: view results.

Test suite: test Meticulous with app url. Last updated for commit 8c50e28. This comment will update as new commits are pushed.

Copy link
Contributor

@Que3216 Que3216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you already used it here, but Alex added a script that helps bump -- just run yarn bump-sdk-version to bump too.

May be worth using it anyway to make sure that everything is bumped consistently across all packages?

@dbook13
Copy link
Contributor Author

dbook13 commented Aug 11, 2023

Not sure if you already used it here, but Alex added a script that helps bump -- just run yarn bump-sdk-version to bump too.

May be worth using it anyway to make sure that everything is bumped consistently across all packages?

I ran that in the monorepo but I don't think that script exists in report-diffs-action. Is it possible to execute that script from within this repo?

@dbook13 dbook13 merged commit 563cae9 into main Aug 14, 2023
5 checks passed
@dbook13 dbook13 deleted the dbook/bump-launcher branch August 14, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants