Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop replay option defaulting #315

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

alexivanov
Copy link
Contributor

This is now BE-driven

Blocked on the BE part of this going live.

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
report-diffs-action ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2023 7:19pm

@github-actions
Copy link

github-actions bot commented Aug 22, 2023

🤖 Meticulous replayed 1 user sessions and took 8 screenshots. Meticulous did not run on main of the main branch and so there was nothing to compare against.

Please merge your pull request for setting up Meticulous in CI and ensure that it’s running on push events to the main branch.

Test suite: test Meticulous with app url. Last updated for commit 6520d2c. This comment will update as new commits are pushed.

Version bump due to moveBeforeClick being toggled to true.
@alexivanov alexivanov requested a review from a team August 22, 2023 19:19
@github-actions
Copy link

github-actions bot commented Aug 22, 2023

🤖 Meticulous replayed 1 user sessions and took 8 screenshots. Meticulous did not run on main of the main branch and so there was nothing to compare against.

Please merge your pull request for setting up Meticulous in CI and ensure that it’s running on push events to the main branch.

Test suite: test Meticulous with deployment url. Last updated for commit 6520d2c. This comment will update as new commits are pushed.

@@ -13,6 +13,6 @@ export const EXPECTED_PERMISSIONS_BLOCK = [
// The version of the environment in which a replay is executed. This should be bumped whenever
// the environment changes in a way that would cause a replay to behave differently, e.g. upgrading to a newer
// replay-orchestrator-launcher version, or changing the version of puppeteer.
export const LOGICAL_ENVIRONMENT_VERSION = 2;
export const LOGICAL_ENVIRONMENT_VERSION = 3;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version bump due to moveBeforeClick being toggled to true as part of the default options switch.

@alexivanov alexivanov merged commit 327315f into main Sep 11, 2023
5 checks passed
@alexivanov alexivanov deleted the drop-replay-option-defaulting branch September 11, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants