Setup proxy to host instead of rewriting URL #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with deployment url. Last updated for commit 5c615d1. This comment will update as new commits are pushed. |
|
✅ Meticulous spotted zero visual differences across 8 screens tested: view results. Test suite: test Meticulous with app url. Last updated for commit 5c615d1. This comment will update as new commits are pushed. |
Que3216
approved these changes
Feb 6, 2024
edoardopirovano
force-pushed
the
edoardo/proxy-to-host
branch
from
82e430d
to
e761e04
Compare
edoardopirovano
force-pushed
the
edoardo/proxy-to-host
branch
from
e761e04
to
7652540
Compare
edoardopirovano
force-pushed
the
edoardo/proxy-to-host
branch
from
7652540
to
d8e2760
Compare
edoardopirovano
force-pushed
the
edoardo/proxy-to-host
branch
from
d8e2760
to
83a697b
Compare
edoardopirovano
force-pushed
the
edoardo/proxy-to-host
branch
from
83a697b
to
4bd40c9
Compare
edoardopirovano
force-pushed
the
edoardo/proxy-to-host
branch
from
4bd40c9
to
5c615d1
Compare
edoardopirovano
added a commit
that referenced
this pull request
Feb 6, 2024
edoardopirovano
added a commit
that referenced
this pull request
Feb 7, 2024
After #386, this connection check no longer makes sense as we can always open a port to the proxy so it isn't really checking anything. Instead, let's try and actually fetch the appUrl and see if the server behind the proxy gives us _something_ back. We don't check the status code other than 502 which is what the proxy will return if it can't connect to the server since this most closely mimics the behaviour of just opening a socket that we had before. This PR also adds in some waiting, so that we'll retry a couple of times to allow for the fact that the server to test against may take a bit of time to spin up. This should avoid the need for customers to add/tweak manual `sleep`s in their workflow. Also, one small fix to an error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should unblock customers using Auth0 which will stop the page load if it sees a non-HTTPS and non-localhost URL.
Sample run on my personal website: https://github.com/edoardopirovano/website/actions/runs/7797651026/job/21267781609
Screenshots in the test run all look good: https://app.meticulous.ai/projects/edoardopirovano/website/test-runs/tnmzLBTmNqDJqQm8LKRpMzQbFd
Viewing a simulation confirms we were hitting
localhostand using the proxy: https://app.meticulous.ai/projects/edoardopirovano/website/simulations/ggGWCJ6kNPnbmKbtGKqpqLDTq7Resolves ENG-862