Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release changes from #386 #387

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Release changes from #386 #387

merged 2 commits into from
Feb 6, 2024

Commits on Feb 6, 2024

  1. Setup proxy to host instead of rewriting URL

    @edoardopirovano
    edoardopirovano committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    5c615d1 View commit details
    Browse the repository at this point in the history

  2. Setup proxy to host instead of rewriting URL (#386) 

    This should unblock customers using Auth0 which will stop the page load
if it sees a non-HTTPS and non-localhost URL.

Sample run on my personal website:
https://github.com/edoardopirovano/website/actions/runs/7797651026/job/21267781609

Screenshots in the test run all look good:
https://app.meticulous.ai/projects/edoardopirovano/website/test-runs/tnmzLBTmNqDJqQm8LKRpMzQbFd

Viewing a simulation confirms we were hitting `localhost` and using the
proxy:
https://app.meticulous.ai/projects/edoardopirovano/website/simulations/ggGWCJ6kNPnbmKbtGKqpqLDTq7

Resolves ENG-862
    @edoardopirovano
    edoardopirovano authored Feb 6, 2024
    Configuration menu
    Copy the full SHA
    1f5837e View commit details
    Browse the repository at this point in the history