Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved logging #24

Open
wants to merge 11 commits into
base: non-admin-users
Choose a base branch
from
Open

Improved logging #24

wants to merge 11 commits into from

Conversation

vishwasmittal
Copy link
Contributor

@vishwasmittal vishwasmittal commented May 17, 2019 •
edited
Loading

fixes #4

@cpg
Copy link
Member

cpg commented Aug 8, 2019

Where are we on this?

@vishwasmittal
Copy link
Contributor Author

vishwasmittal commented Aug 21, 2019 •
edited
Loading

Most of the work is done. Earlier we put this on halt due to low priority but will review the changes again, resolve merge conflicts, and remove the WIP status. @cpg

@vishwasmittal vishwasmittal changed the title [WIP] Improved logging Improved logging Aug 22, 2019
@vishwasmittal
Copy link
Contributor Author

This PR adds:

  • Origin of the request (local/remote/unknown) based on the Host header
  • Logs for denied access and other HTTP errors
  • API to fetch logs (latest logs as well as all logs)
  • Updated the logging interface to use logrus instead of the inbuilt logger.

@vishwasmittal
Copy link
Contributor Author

@csoni111 @cpg, please review this.

csoni111
csoni111 reviewed Aug 24, 2019
View reviewed changes
src/fs/fs.go Outdated
const DisableCertChecking = false
const DisableHttps = false
const DisableCertChecking = true
const DisableHttps = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two options should not be changed, please remove this change from the commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csoni111 Resolved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csoni111 csoni111 csoni111 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

better logging
3 participants
@vishwasmittal @cpg @csoni111