Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Next.js 15 to peer dependencies #1443

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

amannn
Copy link
Owner

@amannn amannn commented Oct 22, 2024

next-intl generally works with Next.js 15.

However, in case you're using i18n routing and the alternate links feature, you might want to wait with upgrading until an upstream bug is resolved in Next.js: #1442. Due to this, I'll delay updating the docs and examples in this repo (#1089).

Fixes #1441
Fixes #1075

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-intl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:38am
next-intl-example-app-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:38am
next-intl-example-app-router-without-i18n-routing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 10:38am

@amannn amannn marked this pull request as ready for review October 22, 2024 10:38
@amannn amannn merged commit 4cb22bb into main Oct 22, 2024
10 checks passed
@@ -91,7 +91,7 @@
"use-intl": "workspace:^"
},
"peerDependencies": {
"next": "^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0",
"next": "^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0 || ^15.0.0",
"react": "^16.8.0 || ^17.0.0 || ^18.0.0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! 😄

Is it also possible to allow React.js v19 in peerDependencies?

Suggested change
"react": "^16.8.0 || ^17.0.0 || ^18.0.0"
"react": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc"

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next.js 15 vendors the React 19 RC anyway, you implicitly get React 19 even if React 18 is installed 🙂.

I'll add official support for React 19 once it hits stable and is generally available, hope that makes sense!

@amannn amannn deleted the feat/support-nextjs-15 branch October 24, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issue after upgrading to Nextjs 15 and Next-Intl 3.22 Support for Next.js 15 RC and React 19 RC
2 participants