fix: Resolve locale for navigation APIs consistently from i18n/request.ts in react-server like all other APIs do (#1459)
#1459
+36
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…react-server` like all other APIs do
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amannn
changed the title
react-server like all other APIs doi18n/request.ts in react-server like all other APIs do (#1459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a locale of
undefinedcould have ended up in your navigation APIs in case the middleware didn't run as part of the request andsetRequestLocalewasn't used. Now, we resolve fromi18n/request.tsfor this case too, potentially taking a fallback locale into account.Note however that this is more often than not the result of an invalid middleware config (see middleware troubleshooting).