Generate alias file #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tobybellwood - should all be sorted now |
src/LagoonCommands.php
Outdated
|
|
||
| foreach ($response->data->project->environments as $env) { | ||
| $details = [ | ||
| "host" => $env->kubernetes->sshHost, |
There was a problem hiding this comment.
we need to handle existing deploytargets here that have no specific ssh host set - otherwise they will return null as the host?
I'm just not sure where to read it from - we could fall back to the lagoon aliases (or a hard coded default?
There was a problem hiding this comment.
@tobybellwood - I think that should do it.
…pal-integrations into feature/generate_alias_file
tobybellwood
reviewed
Sep 1, 2023
src/LagoonCommands.php
Outdated
| @@ -67,11 +77,10 @@ public function __construct() { | |||
| // Get default config. | |||
| $lagoonyml = $this->getLagoonYml(); | |||
| $this->api = $lagoonyml['api'] ?? 'https://api.lagoon.amazeeio.cloud/graphql'; | |||
There was a problem hiding this comment.
to accommodate uselagoon/build-deploy-tool#193
Suggested change
| $this->api = $lagoonyml['api'] ?? 'https://api.lagoon.amazeeio.cloud/graphql'; | |
| $this->api = getenv('LAGOON_CONFIG_API_HOST') ?? $lagoonyml['api'] ?? 'https://api.lagoon.amazeeio.cloud/graphql'; |
tobybellwood
reviewed
Sep 1, 2023
Comment on lines
+21
to
+30
| /** | ||
| * Default ssh host, used for fallback | ||
| */ | ||
| const DEFAULT_SSH_HOST = 'ssh.lagoon.amazeeio.cloud'; | ||
|
|
||
| /** | ||
| * Default ssh port, used for fallback | ||
| */ | ||
| const DEFAULT_SSH_PORT = 32222; | ||
|
|
There was a problem hiding this comment.
we'd ideally make a function here to handle uselagoon/build-deploy-tool#193 and fallback defaults to use in a chained null coalesce as per the api. We can probably assume that the last chance fallback doesn't need to be host and port configurable though?
|
also getting failures on drush 12 (but not drush 11) trying to use one of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a command to generate a file of aliases - this is particularly useful when dealing with sites that live on separate clusters when accessing via the ssh-portal