This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Check buffer after each record is added #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the buffer is not overfilled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GetRecords is called it does not appear to adhere to the buffer limits that have been put in place. This results in Buffers which can in some cases far exceed what is safe for an emitter to actually send.
This results in either the need to re-split the buffer within the Emitter to ensure that the buffer size is within a manageable range or simply resulting in the emitter failing to push the Buffer to its target due to size constraints of the sink.