Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI, depend on newest Braket.jl and get doc build working #2

Merged
merged 10 commits into from
Apr 26, 2024

Conversation

kshyatt-aws
Copy link
Contributor

@kshyatt-aws kshyatt-aws commented Apr 25, 2024

Issue #, if available:

Description of changes: Add a CI.yml that runs the unit tests and doctests

Testing done: CI passes

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner April 25, 2024 17:17
@kshyatt-aws
Copy link
Contributor Author

Looks like CI is failing due to coverage being unable to POST

@AbeCoull
Copy link

AbeCoull commented Apr 25, 2024

Looks like CI is failing due to coverage being unable to POST

Have you already added the repo to Coveralls @kshyatt-aws ? I was having trouble finding a reference to it.

@kshyatt-aws
Copy link
Contributor Author

Not yet, I'll try to do so now

@kshyatt-aws kshyatt-aws requested a review from AbeCoull April 25, 2024 20:31
krneta
krneta previously approved these changes Apr 25, 2024
krneta
krneta previously approved these changes Apr 25, 2024
Copy link

codecov bot commented Apr 26, 2024

The author of this PR, kshyatt-aws, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@kshyatt-aws kshyatt-aws merged commit 2d79fcb into main Apr 26, 2024
10 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/gh_updates branch April 26, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants