Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions for some tests #4

Merged
merged 2 commits into from
Apr 27, 2024
Merged

Add descriptions for some tests #4

merged 2 commits into from
Apr 27, 2024

Conversation

speller26
Copy link
Member

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@speller26 speller26 requested a review from kshyatt-aws April 26, 2024 07:30
@speller26 speller26 requested a review from a team as a code owner April 26, 2024 07:30
Copy link
Contributor

@kshyatt-aws kshyatt-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some of the translation tests it'd be nice to include the name of the thing we're testing with interpolation, otherwise lgtm

test/test_python_ext.jl Outdated Show resolved Hide resolved
test/test_python_ext.jl Outdated Show resolved Hide resolved
test/test_python_ext.jl Outdated Show resolved Hide resolved
test/test_python_ext.jl Outdated Show resolved Hide resolved
test/test_python_ext.jl Outdated Show resolved Hide resolved
test/test_python_ext.jl Outdated Show resolved Hide resolved
test/test_python_ext.jl Outdated Show resolved Hide resolved
test/test_python_ext.jl Outdated Show resolved Hide resolved
test/test_python_ext.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@cd25df6). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   77.54%           
=======================================
  Files           ?       15           
  Lines           ?     2071           
  Branches        ?        0           
=======================================
  Hits            ?     1606           
  Misses          ?      465           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speller26 speller26 requested a review from krneta April 26, 2024 21:33
@speller26 speller26 merged commit f8a580e into main Apr 27, 2024
10 checks passed
@speller26 speller26 deleted the labels branch April 27, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants