Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix indexing to use 1-based and use proper type in tests #9

Merged
merged 2 commits into from
May 1, 2024

Conversation

kshyatt-aws
Copy link
Contributor

Issue #, if available: N/A

Description of changes: The Julia wrapper around Python lists is PyList. In the tests, we were constructing a raw Python list (which has type Py) and passing it to the extension method. This PR tightens up the acceptable types in the extension method and fixes the indexing.

Testing done: Unit tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner May 1, 2024 18:21
@kshyatt-aws
Copy link
Contributor Author

Tested this with my local install of amazon-braket-simulator-v2-python and its unit tests passed too. To do the same edit juliapkg.json and make rev="ksh/index_fix".

Copy link

codecov bot commented May 1, 2024

The author of this PR, kshyatt-aws, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@krneta krneta merged commit 964ae80 into main May 1, 2024
11 checks passed
@krneta krneta deleted the ksh/index_fix branch May 1, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants