Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update pytest version to fix security vuln #277

Merged

Conversation

chookity-pokk
Copy link
Contributor

Issue #, if available:

Description of changes:
Updating pytest version to get past security vulnerability.

GHSA-w596-4wvx-j9j6

Testing done:
All tests passed locally when running the Run the Unit Tests commands in Contributing.md.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chookity-pokk chookity-pokk requested a review from a team as a code owner February 7, 2025 19:52
@chookity-pokk
Copy link
Contributor Author

For a bit of context, I know the security issue doesn't really apply since it's specific to svn but we consume amazon-braket-sdk which consumes this package so we end up with security bug notices that we have to fix. I figured the best course of action was to upstream this small change. Please let me know if there is a better way of going about this!

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (209c994) to head (a179fd1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #277   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         3803      3803           
  Branches       396       396           
=========================================
  Hits          3803      3803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chookity-pokk
Copy link
Contributor Author

@rmshaffer Is there any chance that after this is merged that a release can be done so it can be consumed upstream in amazon-braket-sdk? That way I can consume it down stream and fix my security vulnerability?

@rmshaffer rmshaffer merged commit 752cf0c into amazon-braket:main Feb 7, 2025
33 checks passed
@rmshaffer
Copy link
Contributor

@chookity-pokk Yes, for sure, we'll get a release out. It may not be until next week though. I will update you here when it's done. Thanks again for jumping in and contributing the fix here.

@chookity-pokk
Copy link
Contributor Author

@chookity-pokk Yes, for sure, we'll get a release out. It may not be until next week though. I will update you here when it's done. Thanks again for jumping in and contributing the fix here.

No worries about the next week release date. Happy to help! Thank you for making this open source so I'm able to help!

@rmshaffer
Copy link
Contributor

@chookity-pokk v1.26.4 is released to pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants