-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persist circuits in batch execute #260
Merged
yitchen-tim
merged 10 commits into
amazon-braket:feature/persist-batch-circuits
from
WingCode:persist-batch-circuits
Jun 12, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f0f7071
feature: persist circuits in batch execute
WingCode dd28a69
feature: Add test for batch_execute persistance
WingCode 67aeaae
fix: circuits attribute
WingCode 9e01ab1
documentation: add doc for printing circuits from batch_execute
WingCode 5a0766e
Merge branch 'main' into persist-batch-circuits
rmshaffer 1eb0a6d
fix: linting
WingCode 6616e4b
Merge branch 'main' into persist-batch-circuits
WingCode 24a8168
Merge branch 'main' into persist-batch-circuits
rmshaffer a17e8b9
Merge branch 'main' into persist-batch-circuits
yitchen-tim 70adc56
Add tasks, circuits
WingCode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self._circuits
here is a private variable. that users should not access. Instead, users access _circuits through properties. So, there need to be a new property of this class calledcircuits
defined as a method of the class, similar toamazon-braket-pennylane-plugin-python/src/braket/pennylane_plugin/braket_device.py
Line 174 in a17e8b9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And yes, it's a bit repetitive now that we have both
circuits
andcircuit
, but I think it's okay for now. In long term,circuit
may be deprecated.