New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clob refactoring #164

Merged

zslayton merged 4 commits into amazon-ion:master from R-maan:clob-refactoring

Sep 18, 2020

Contributor

R-maan commented Sep 17, 2020

This pull request contains some refactoring for reading Clobs:

Separates reading of clob from string, which Resolves Refactor clob reading #144; done in this commit: b9a8adf
Simplifies the logic for reaching at the end of a long string which Resolves Refactor skipper.skipEndOfLongString() #61; done in this commit: 9918dcb

Arman A added 4 commits

September 17, 2020 15:16


          Separate reading of clob from reading of string

b9a8adf


          Minor refactor in reading long strings

9918dcb


          Fix empty clob

80cab63


          Improve comment

e9f12fd

zslayton approved these changes

View reviewed changes

zslayton merged commit 244bcc5 into amazon-ion:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet