Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ion-hash-test submodule and applies fixes to BigListOfNaughtyStringTests.ts #24

Merged
merged 3 commits into from
Oct 24, 2019

Conversation

pbcornell
Copy link

  • Updates BigListOfNaughtyStringsTests to properly recognize the 'invalid_ion::' prefix, and to use 'md5' for hashing
    • The runTest() method previously constructed a TestValue object based on testString, from which any ion:: or invalid_ion:: prefix has been removed, so the value of TestValue.isValidIon is incorrect. These changes address that bug
    • Also changes the hash algorithm from 'identity' to 'md5' to enable comparison with other Ion Hash implementations
  • Adds the ion-hash-test submodule and updates README.md
  • Updates BigListOfNaughtyStringsTests.ts to use ion-hash-test/big_list_of_naughty_strings.txt
  • Removes tests/big-list-of-naughty-strings.txt

I've also opened #23 to update IonHashTests.ts to use ion-hash-test/ion_hash_tests.ion once $0 is supported.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pbcornell pbcornell requested review from zslayton and wesboyt October 24, 2019 19:07
@pbcornell pbcornell merged commit 7390a90 into master Oct 24, 2019
@pbcornell pbcornell deleted the pcornell-update-blons-test branch October 24, 2019 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants