Avoids using lambdas in MacroEvaluator hot paths. #1045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
These three lambdas were all in the top 9 contributors to total allocations when reading test data. After this change, they're gone. Note: the new allocation profile results show that the JVM optimizes away the no-op lambda.
Also note: beginning with this PR I've moved to version of the test dataset that does not use
make_string
invocations, as they are an optional feature that users may choose to use when data size is more important than read performance. As a result, these numbers are not directly comparable to the numbers in preceding PRs.Speed: 219 ms/op -> 219 ms/op (0%)
Allocation rate: 124 KB/op -> 113 KB/op (-8.9%)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.