adds changes to allow open content within schema and adds APIs to retrieve open content #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rive open content * adds open_content() in IslType as well IslSchema to retrieve open content * adds load_isl_schema() that load a schema content as an intrernal ISL model which can be programmaticlaly manipulated * adds related tests for open content
popematt
reviewed
Feb 1, 2023
popematt
reviewed
Feb 5, 2023
| inline_imported_types: Vec<IslImportType>, | ||
| /// Represents open content as `Element`s | ||
| /// Note: This doesn't preserve the information about where the open content is placed in the schema file. |
There was a problem hiding this comment.
Can you document why you have chosen to do it this way? It's possible that in a year, there will be a use case that requires the relative ordering of ISL and non-ISL. If that comes up, we need to understand why the decision was made so that we can make an informed decision about whether to change it.
There was a problem hiding this comment.
As of now I do not know of any use case for preserving this information and it requires storing the order for non ISL and ISL which could complicate the current IslSchema model by having to store the order and add a model to represent non ISL data. If a use case arrives we can change it.
popematt
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #6
Description of changes:
This PR works on adding changes for allowing open content within schema and adds APIs to retrieve open content.
List of changes:
open_content()inIslTypeas wellIslSchemato retrieve open contentload_isl_schema()that load a schema content as an internal ISL model which can be programmatically manipulatedNote:
IslSchema#open_content()only provides top level open content. For open content in type definition addedIslType#open_content()Test:
systemandislmodulesion-schema-teststo verify open content is allowedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.