Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 21 git workdir in private storage #18

Closed
wants to merge 2 commits into from

Conversation

amberin
Copy link
Owner

@amberin amberin commented Nov 4, 2023

What has changed and why?

Related issues

Checklist (delete item if not applicable)

  • I have added a user-friendly description of this change to app/src/main/res/layout/dialog_whats_new.xml

and remove all Git settings related to the workdir location.

The directory containing the workdir is named using the repo ID. This
should allow changing the URL of an existing repo.

I thought for a while about a feature to copy/export the directory to
public storage for troubleshooting purposes, but I came to the
conclusion that it should not be necessary. If the user is worried about
losing local state, they can always export the relevant notebooks as
text files, and re-import them later. If the repo is somehow broken, it
is best to delete it and add a new one, re-linking the notebooks (and
deleting the local copies, if necessary). If there are tenacious bugs,
they should be ironed out on a virtual device with full root access.

This resolves #21.
… git repos"

This should no longer be needed, as we now create Git workdirs in
private storage.

This reverts commit 0d0dc29.
@amberin amberin closed this Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant