Bug 1628715 - Part 7: Add MOZ_NONNULL_RETURN to infallible nsTArray::…

…AppendElements. r=xpcom-reviewers,necko-reviewers,nika,valentin

Differential Revision: https://phabricator.services.mozilla.com/D70831

accessible/base/EventQueue.cpp

@@ -31,7 +31,9 @@ bool EventQueue::PushEvent(AccEvent* aEvent) {
                    aEvent->Document() == mDocument,
                "Queued event belongs to another document!");
 
-  if (!mEvents.AppendElement(aEvent)) return false;
+  // XXX(Bug 1631371) Check if this should use a fallible operation as it
+  // pretended earlier, or change the return type to void.
+  mEvents.AppendElement(aEvent);
 
   // Filter events.
   CoalesceEvents();

accessible/base/NotificationController.h

@@ -198,7 +198,10 @@ class NotificationController final : public EventQueue,
    * Pend an accessible subtree relocation.
    */
   void ScheduleRelocation(Accessible* aOwner) {
-    if (!mRelocations.Contains(aOwner) && mRelocations.AppendElement(aOwner)) {
+    if (!mRelocations.Contains(aOwner)) {
+      // XXX(Bug 1631371) Check if this should use a fallible operation as it
+      // pretended earlier, or change the return type to void.
+      mRelocations.AppendElement(aOwner);
       ScheduleProcessing();
     }
   }
@@ -234,8 +237,12 @@ class NotificationController final : public EventQueue,
 
     RefPtr<Notification> notification =
         new TNotification<Class, Args...>(aInstance, aMethod, aArgs...);
-    if (notification && mNotifications.AppendElement(notification))
+    if (notification) {
+      // XXX(Bug 1631371) Check if this should use a fallible operation as it
+      // pretended earlier.
+      mNotifications.AppendElement(notification);
       ScheduleProcessing();
+    }
   }
 
   /**
@@ -249,8 +256,12 @@ class NotificationController final : public EventQueue,
       Class* aInstance, typename TNotification<Class>::Callback aMethod) {
     RefPtr<Notification> notification =
         new TNotification<Class>(aInstance, aMethod);
-    if (notification && mNotifications.AppendElement(notification))
+    if (notification) {
+      // XXX(Bug 1631371) Check if this should use a fallible operation as it
+      // pretended earlier.
+      mNotifications.AppendElement(notification);
       ScheduleProcessing();
+    }
   }
 
   template <class Class, class Arg>
@@ -259,7 +270,10 @@ class NotificationController final : public EventQueue,
       Arg* aArg) {
     RefPtr<Notification> notification =
         new TNotification<Class, Arg>(aInstance, aMethod, aArg);
-    if (notification && mNotifications.AppendElement(notification)) {
+    if (notification) {
+      // XXX(Bug 1631371) Check if this should use a fallible operation as it
+      // pretended earlier.
+      mNotifications.AppendElement(notification);
       ScheduleProcessing();
     }
   }

accessible/generic/Accessible.cpp

@@ -2130,8 +2130,9 @@ bool Accessible::InsertChildAt(uint32_t aIndex, Accessible* aChild) {
   if (!aChild) return false;
 
   if (aIndex == mChildren.Length()) {
-    if (!mChildren.AppendElement(aChild)) return false;
-
+    // XXX(Bug 1631371) Check if this should use a fallible operation as it
+    // pretended earlier.
+    mChildren.AppendElement(aChild);
   } else {
     // XXX(Bug 1631371) Check if this should use a fallible operation as it
     // pretended earlier.

accessible/generic/DocAccessible.h

@@ -424,7 +424,10 @@ class DocAccessible : public HyperTextAccessibleWrap,
    * accessibles.
    */
   bool AppendChildDocument(DocAccessible* aChildDocument) {
-    return mChildDocuments.AppendElement(aChildDocument);
+    // XXX(Bug 1631371) Check if this should use a fallible operation as it
+    // pretended earlier, or change the return type to void.
+    mChildDocuments.AppendElement(aChildDocument);
+    return true;
   }
 
   /**

docshell/base/nsDocShellEnumerator.cpp

@@ -74,7 +74,7 @@ nsresult nsDocShellEnumerator::BuildArrayRecursiveBackwards(
   // add this item to the array
   if (mDocShellType == nsIDocShellTreeItem::typeAll ||
       aItem->ItemType() == mDocShellType) {
-    if (!aItemArray.AppendElement(aItem)) {
+    if (!aItemArray.AppendElement(aItem, fallible)) {
       return NS_ERROR_OUT_OF_MEMORY;
     }
   }

dom/base/CustomElementRegistry.cpp

@@ -692,10 +692,9 @@ bool CustomElementRegistry::JSObjectToAtomArray(
         return false;
       }
 
-      if (!aArray.AppendElement(NS_Atomize(attrStr))) {
-        aRv.Throw(NS_ERROR_OUT_OF_MEMORY);
-        return false;
-      }
+      // XXX(Bug 1631371) Check if this should use a fallible operation as it
+      // pretended earlier.
+      aArray.AppendElement(NS_Atomize(attrStr));
     }
   }
 

dom/base/DOMStringList.h

@@ -57,9 +57,11 @@ class DOMStringList : public nsISupports, public nsWrapperCache {
   }
 
   bool Add(const nsAString& aName) {
-    // XXXbz mNames should really be a fallible array; otherwise this
-    // return value is meaningless.
-    return mNames.AppendElement(aName) != nullptr;
+    // XXXbz(Bug 1631374) mNames should really be a fallible array; otherwise
+    // this return value is meaningless. return mNames.AppendElement(aName) !=
+    // nullptr;
+    mNames.AppendElement(aName);
+    return true;
   }
 
   void Clear() { mNames.Clear(); }

dom/base/Selection.cpp

@@ -970,9 +970,9 @@ nsresult Selection::StyledRanges::MaybeAddRangeAndTruncateOverlaps(
 
   // a common case is that we have no ranges yet
   if (mRanges.Length() == 0) {
-    if (!mRanges.AppendElement(StyledRange(aRange))) {
-      return NS_ERROR_OUT_OF_MEMORY;
-    }
+    // XXX(Bug 1631371) Check if this should use a fallible operation as it
+    // pretended earlier.
+    mRanges.AppendElement(StyledRange(aRange));
     aRange->RegisterSelection(aSelection);
 
     *aOutIndex = 0;
@@ -1175,8 +1175,9 @@ nsresult Selection::GetRangesForIntervalArray(
   if (startIndex == -1 || endIndex == -1) return NS_OK;
 
   for (int32_t i = startIndex; i < endIndex; i++) {
-    if (!aRanges->AppendElement(mStyledRanges.mRanges[i].mRange))
-      return NS_ERROR_OUT_OF_MEMORY;
+    // XXX(Bug 1631371) Check if this should use a fallible operation as it
+    // pretended earlier.
+    aRanges->AppendElement(mStyledRanges.mRanges[i].mRange);
   }
 
   return NS_OK;

dom/base/nsAttrValue.cpp

@@ -290,11 +290,13 @@ void nsAttrValue::SetTo(const nsAttrValue& aOther) {
       break;
     }
     case eAtomArray: {
-      if (!EnsureEmptyAtomArray() ||
-          !GetAtomArrayValue()->AppendElements(*otherCont->mValue.mAtomArray)) {
+      if (!EnsureEmptyAtomArray()) {
         Reset();
         return;
       }
+      // XXX(Bug 1631371) Check if this should use a fallible operation as it
+      // pretended earlier.
+      GetAtomArrayValue()->AppendElements(*otherCont->mValue.mAtomArray);
       break;
     }
     case eDoubleValue: {
@@ -1125,10 +1127,9 @@ void nsAttrValue::ParseAtomArray(const nsAString& aValue) {
 
   AtomArray* array = GetAtomArrayValue();
 
-  if (!array->AppendElement(std::move(classAtom))) {
-    Reset();
-    return;
-  }
+  // XXX(Bug 1631371) Check if this should use a fallible operation as it
+  // pretended earlier.
+  array->AppendElement(std::move(classAtom));
 
   // parse the rest of the classnames
   while (iter != end) {
@@ -1140,10 +1141,9 @@ void nsAttrValue::ParseAtomArray(const nsAString& aValue) {
 
     classAtom = NS_AtomizeMainThread(Substring(start, iter));
 
-    if (!array->AppendElement(std::move(classAtom))) {
-      Reset();
-      return;
-    }
+    // XXX(Bug 1631371) Check if this should use a fallible operation as it
+    // pretended earlier.
+    array->AppendElement(std::move(classAtom));
 
     // skip whitespace
     while (iter != end && nsContentUtils::IsHTMLWhitespace(*iter)) {

dom/base/nsLineBreaker.cpp

@@ -61,9 +61,9 @@ static void SetupCapitalization(const char16_t* aWord, uint32_t aLength,
 nsresult nsLineBreaker::FlushCurrentWord() {
   uint32_t length = mCurrentWord.Length();
   AutoTArray<uint8_t, 4000> breakState;
-  if (!breakState.AppendElements(length)) {
-    return NS_ERROR_OUT_OF_MEMORY;
-  }
+  // XXX(Bug 1631371) Check if this should use a fallible operation as it
+  // pretended earlier.
+  breakState.AppendElements(length);
 
   nsTArray<bool> capitalizationState;
 
@@ -128,8 +128,9 @@ nsresult nsLineBreaker::FlushCurrentWord() {
 
       if (!mWordContinuation && (ti->mFlags & BREAK_NEED_CAPITALIZATION)) {
         if (capitalizationState.Length() == 0) {
-          if (!capitalizationState.AppendElements(length))
-            return NS_ERROR_OUT_OF_MEMORY;
+          // XXX(Bug 1631371) Check if this should use a fallible operation as
+          // it pretended earlier.
+          capitalizationState.AppendElements(length);
           memset(capitalizationState.Elements(), false, length * sizeof(bool));
           SetupCapitalization(mCurrentWord.Elements(), length,
                               capitalizationState.Elements());
@@ -192,14 +193,17 @@ nsresult nsLineBreaker::AppendText(nsAtom* aHyphenationLanguage,
 
   AutoTArray<uint8_t, 4000> breakState;
   if (aSink) {
-    if (!breakState.AppendElements(aLength)) return NS_ERROR_OUT_OF_MEMORY;
+    // XXX(Bug 1631371) Check if this should use a fallible operation as it
+    // pretended earlier.
+    breakState.AppendElements(aLength);
   }
 
   bool noCapitalizationNeeded = true;
   nsTArray<bool> capitalizationState;
   if (aSink && (aFlags & BREAK_NEED_CAPITALIZATION)) {
-    if (!capitalizationState.AppendElements(aLength))
-      return NS_ERROR_OUT_OF_MEMORY;
+    // XXX(Bug 1631371) Check if this should use a fallible operation as it
+    // pretended earlier.
+    capitalizationState.AppendElements(aLength);
     memset(capitalizationState.Elements(), false, aLength * sizeof(bool));
     noCapitalizationNeeded = false;
   }
@@ -370,7 +374,9 @@ nsresult nsLineBreaker::AppendText(nsAtom* aHyphenationLanguage,
 
   AutoTArray<uint8_t, 4000> breakState;
   if (aSink) {
-    if (!breakState.AppendElements(aLength)) return NS_ERROR_OUT_OF_MEMORY;
+    // XXX(Bug 1631371) Check if this should use a fallible operation as it
+    // pretended earlier.
+    breakState.AppendElements(aLength);
   }
 
   uint32_t start = offset;

dom/console/Console.cpp

@@ -2919,10 +2919,8 @@ bool Console::ArgumentData::Initialize(JSContext* aCx,
                                        const Sequence<JS::Value>& aArguments) {
   mGlobal = JS::CurrentGlobalOrNull(aCx);
 
-  for (uint32_t i = 0; i < aArguments.Length(); ++i) {
-    if (NS_WARN_IF(!mArguments.AppendElement(aArguments[i]))) {
-      return false;
-    }
+  if (NS_WARN_IF(!mArguments.AppendElements(aArguments, fallible))) {
+    return false;
   }
 
   return true;

dom/html/HTMLFormControlsCollection.cpp

@@ -208,22 +208,21 @@ nsresult HTMLFormControlsCollection::GetSortedControls(
       NS_ASSERTION(notInElementsIdx < notInElementsLen,
                    "Should have remaining not-in-elements");
       // Append the remaining mNotInElements elements
-      if (!aControls.AppendElements(
-              mNotInElements.Elements() + notInElementsIdx,
-              notInElementsLen - notInElementsIdx)) {
-        return NS_ERROR_OUT_OF_MEMORY;
-      }
+      // XXX(Bug 1631371) Check if this should use a fallible operation as it
+      // pretended earlier.
+      aControls.AppendElements(mNotInElements.Elements() + notInElementsIdx,
+                               notInElementsLen - notInElementsIdx);
       break;
     }
     // Check whether we're done with mNotInElements
     if (notInElementsIdx == notInElementsLen) {
       NS_ASSERTION(elementsIdx < elementsLen,
                    "Should have remaining in-elements");
       // Append the remaining mElements elements
-      if (!aControls.AppendElements(mElements.Elements() + elementsIdx,
-                                    elementsLen - elementsIdx)) {
-        return NS_ERROR_OUT_OF_MEMORY;
-      }
+      // XXX(Bug 1631371) Check if this should use a fallible operation as it
+      // pretended earlier.
+      aControls.AppendElements(mElements.Elements() + elementsIdx,
+                               elementsLen - elementsIdx);
       break;
     }
     // Both lists have elements left.
@@ -242,9 +241,9 @@ nsresult HTMLFormControlsCollection::GetSortedControls(
       ++notInElementsIdx;
     }
     // Add the first element to the list.
-    if (!aControls.AppendElement(elementToAdd)) {
-      return NS_ERROR_OUT_OF_MEMORY;
-    }
+    // XXX(Bug 1631371) Check if this should use a fallible operation as it
+    // pretended earlier.
+    aControls.AppendElement(elementToAdd);
   }
 
   NS_ASSERTION(aControls.Length() == elementsLen + notInElementsLen,

dom/media/MediaCache.cpp

@@ -920,7 +920,9 @@ int32_t MediaCache::FindBlockForIncomingData(AutoLock& aLock, TimeStamp aNow,
          PredictNextUseForIncomingData(aLock, aStream) >=
              PredictNextUse(aLock, aNow, blockIndex))) {
       blockIndex = mIndex.Length();
-      if (!mIndex.AppendElement()) return -1;
+      // XXX(Bug 1631371) Check if this should use a fallible operation as it
+      // pretended earlier.
+      mIndex.AppendElement();
       mIndexWatermark = std::max(mIndexWatermark, blockIndex + 1);
       mFreeBlocks.AddFirstBlock(blockIndex);
       return blockIndex;

dom/media/MediaStreamTrack.cpp

@@ -497,7 +497,10 @@ void MediaStreamTrack::NotifyEnabledChanged() {
 
 bool MediaStreamTrack::AddPrincipalChangeObserver(
     PrincipalChangeObserver<MediaStreamTrack>* aObserver) {
-  return mPrincipalChangeObservers.AppendElement(aObserver) != nullptr;
+  // XXX(Bug 1631371) Check if this should use a fallible operation as it
+  // pretended earlier.
+  mPrincipalChangeObservers.AppendElement(aObserver);
+  return true;
 }
 
 bool MediaStreamTrack::RemovePrincipalChangeObserver(

dom/media/platforms/agnostic/bytestreams/AnnexB.cpp

@@ -293,9 +293,9 @@ bool AnnexB::ConvertSampleToAVCC(mozilla::MediaRawData* aSample,
       0xe0 /* num SPS (0) */,
       0 /* num PPS (0) */
   };
-  if (!extradata->AppendElements(kFakeExtraData, ArrayLength(kFakeExtraData))) {
-    return false;
-  }
+  // XXX(Bug 1631371) Check if this should use a fallible operation as it
+  // pretended earlier.
+  extradata->AppendElements(kFakeExtraData, ArrayLength(kFakeExtraData));
   aSample->mExtraData = std::move(extradata);
   return true;
 }

dom/plugins/base/nsNPAPIPluginInstance.cpp

@@ -773,11 +773,9 @@ nsresult nsNPAPIPluginInstance::PushPopupsEnabledState(bool aEnabled) {
           aEnabled ? PopupBlocker::openAllowed : PopupBlocker::openAbused,
           true);
 
-  if (!mPopupStates.AppendElement(oldState)) {
-    // Appending to our state stack failed, pop what we just pushed.
-    PopupBlocker::PopPopupControlState(oldState);
-    return NS_ERROR_FAILURE;
-  }
+  // XXX(Bug 1631371) Check if this should use a fallible operation as it
+  // pretended earlier.
+  mPopupStates.AppendElement(oldState);
 
   return NS_OK;
 }

dom/script/ScriptLoader.h

@@ -340,7 +340,10 @@ class ScriptLoader final : public nsISupports {
   nsresult ProcessOffThreadRequest(ScriptLoadRequest* aRequest);
 
   bool AddPendingChildLoader(ScriptLoader* aChild) {
-    return mPendingChildLoaders.AppendElement(aChild) != nullptr;
+    // XXX(Bug 1631371) Check if this should use a fallible operation as it
+    // pretended earlier. Else, change the return type to void.
+    mPendingChildLoaders.AppendElement(aChild);
+    return true;
   }
 
   mozilla::dom::DocGroup* GetDocGroup() const {