-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements the effect of reflected inertia #12
base: master
Are you sure you want to change the base?
Conversation
fe16f11
to
55dc6ad
Compare
55dc6ad
to
2dcc14f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @amcastro-tri)
multibody/tree/multibody_tree.cc, line 893 at r1 (raw file):
// Add the effect of reflected inertias. for (int v = 0; v < num_velocities(); ++v) { (*tau_array)(v) += reflected_inertia_(v) * known_vdot(v);
Oh, that's easy! Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @sherm1)
multibody/tree/multibody_tree.cc, line 893 at r1 (raw file):
Previously, sherm1 (Michael Sherman) wrote…
Oh, that's easy! Nice.
yeah, I believe it's correct. I essentially wrote the Lagrangian of the system including the new kinetic energy terms due to the actuators. Since those only add a "diagonal mass matrix" independent of positions q, the Coriolis terms remain the same and the only thing that changes is the mass matrix that now includes those new diagonals.
That is, if D is the diagonal matrix that contains the reflected inertias such that 1/2⋅vᵀ⋅D⋅v is the additional kinetic energy due to the rotation of the rotors, then the updated equations of motion read:
(M+D)⋅v̇ + C(q,v) = τ(q,v)
C and whatever is on the right hand side remain unchanged.
I believe this analysis is correct, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @mitiguy)
multibody/tree/multibody_tree.cc, line 893 at r1 (raw file):
Previously, amcastro-tri (Alejandro Castro) wrote…
yeah, I believe it's correct. I essentially wrote the Lagrangian of the system including the new kinetic energy terms due to the actuators. Since those only add a "diagonal mass matrix" independent of positions q, the Coriolis terms remain the same and the only thing that changes is the mass matrix that now includes those new diagonals.
That is, if D is the diagonal matrix that contains the reflected inertias such that 1/2⋅vᵀ⋅D⋅v is the additional kinetic energy due to the rotation of the rotors, then the updated equations of motion read:(M+D)⋅v̇ + C(q,v) = τ(q,v)
C and whatever is on the right hand side remain unchanged.
I believe this analysis is correct, what do you think?
Looks right to me. Of course a real model of the rotor would have mass and other inertias that would affect C and off-diagonal terms in M. But I think this is right for the approximation. Any thoughts on this @mitiguy ?
what the title says. Only the math per Featherstone's book.
This branch does not contain unit testing.
This change is![Reviewable](https://camo.githubusercontent.com/1541c4039185914e83657d3683ec25920c672c6c5c7ab4240ee7bff601adec0b/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)