-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for RH SNP Guest launch on the RH host #28
Draft
LakshmiSaiHarika
wants to merge
11
commits into
amd:main
Choose a base branch
from
LakshmiSaiHarika:rh-snp-guest-launch-rh-host
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Support for RH SNP Guest launch on the RH host #28
LakshmiSaiHarika
wants to merge
11
commits into
amd:main
from
LakshmiSaiHarika:rh-snp-guest-launch-rh-host
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LakshmiSaiHarika
force-pushed
the
rh-snp-guest-launch-rh-host
branch
4 times, most recently
from
January 13, 2025 22:52
b420ef3
to
a257e9a
Compare
Signed-off-by: Harika Nittala <[email protected]>
… a separate SNP guest This supports launch of various SNP Guests at the same time using unique guest name and guest qemu port. A separate SNP guest can be launched with the --guest-name and --guest-port command option as follows: ./snp.sh launch-guest --guest-name <user-guest-name> --guest-port <user-guest-port> Signed-off-by: Harika Nittala <[email protected]>
Updated to show the correct details for the guest SSH access. Signed-off-by: Harika Nittala <[email protected]>
…tion process Updated the ubuntu guest download process to download it once and re-use the same image to quickly create multiple guests with the improved performance. Update of the guest image download structure in ubuntu also helps to easily add support for the same in the other OS linux distros. Signed-off-by: Harika Nittala <[email protected]>
Modularized guest seed image creation in ubuntu to standardize this process across non-debian OS linux distros that has no support for cloud-localds utility supported in canonical distribution. Signed-off-by: Harika Nittala <[email protected]>
Generalize a way to get and install SNP guest kernel package(AMDSEV build), generalize initrd pattern to make it match across different OS linux distros(initrd/initramfs), and set the default ubuntu guest kernel append parameter. Signed-off-by: Harika Nittala <[email protected]>
This feature downloads guest image from fedora guest URL and creates guest seed image from the user-data and meta-data file using genisoimage utility(supported in non-debian OSes). Signed-off-by: Harika Nittala <[email protected]>
Added fedora support to install SNP kernel package on fedora host. Copied guest initrd file from the guest home directory(with modified permission) to the host for the safe initrd file transfer into the host without user permission issue. Updated fedora guest kernel append for the SNP guest launch. Signed-off-by: Harika Nittala <[email protected]>
…mage on RH host User can launch SNP RH guest image for the existing RHEL image(cloud-init configured) via new --rhel-image command option as follows: ./snp.sh launch-guest --rhel-image <user configured RHEL image> Signed-off-by: Harika Nittala <[email protected]>
Added additional guest options ( --guest-dir, --guest-key-path, --guest-user ) to support SNP guest launch for the specific guest working dir, guest SSH key path and guest user name. It could be used in the launch of specific SNP RHEL image as follows: ./snp.sh launch-guest --rhel-image <user configured RHEL guest image path> \ --guest-key-path <user RHEL guest private SSH key file path > \ --guest-user <user RHEL guest user name> \ --guest-dir <user RHEL guest directory path> Signed-off-by: Harika Nittala <[email protected]>
… the RHEL host Added file cleanup steps (guest kernel file, source-bin files) to support the SNP guest launch (ubuntu/RH) from the RH host at the same time. Signed-off-by: Harika Nittala <[email protected]>
LakshmiSaiHarika
force-pushed
the
rh-snp-guest-launch-rh-host
branch
from
January 15, 2025 22:10
a257e9a
to
0434e16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can launch SNP RH Guest on the RH host via the existing RHEL image using additional command options as follows:
Built on top of PR #27 (PR to support Fedora SNP guest launch on Fedora host)
User can launch SNP ubuntu guest on the RH host if RHEL image doesn't exist using my forked branch
ubuntu-snp-gust-launch-rh-host
(branch link here)