fix(one-app-bundler): hash css module classes from files in node_modu…

…les (#613)

Co-authored-by: Matthew Mallimo <[email protected]>

packages/one-app-bundler/__tests__/webpack/loaders/styles-loader.spec.js

@@ -35,20 +35,9 @@ describe('styles-loader', () => {
       getOptions: mockGetOptions,
     });
   });
-  it('should call the loadStyles util with the correct params, for non-node_modules', () => {
+  it('should call the loadStyles util from the dev bundler with the correct params', () => {
     expect(stylesLoader()).toBe('let mockJsContent = "helloMockContent"');
     expect(loadStyles).toHaveBeenCalledTimes(1);
     expect(loadStyles).toHaveBeenCalledWith({ bundleType: BUNDLE_TYPES.BROWSER, cssModulesOptions: { generateScopedName: undefined }, path: 'style/path/mock.scss' });
   });
-  it('should call the loadStyles util with the correct params, for node_modules', () => {
-    stylesLoader = unboundStylesLoader.bind({
-      resourcePath: 'node_modules/style/path/mock.scss',
-      getOptions: mockGetOptions,
-    });
-
-    expect(stylesLoader()).toBe('let mockJsContent = "helloMockContent"');
-
-    expect(loadStyles).toHaveBeenCalledTimes(1);
-    expect(loadStyles).toHaveBeenCalledWith({ bundleType: BUNDLE_TYPES.BROWSER, cssModulesOptions: { generateScopedName: '[local]' }, path: 'node_modules/style/path/mock.scss' });
-  });
 });

packages/one-app-bundler/webpack/loaders/styles-loader.js

@@ -15,10 +15,8 @@
 import { loadStyles } from '@americanexpress/one-app-dev-bundler';
 
 function stylesLoader() {
-  const options = { ...this.getOptions() };
-  // use default for directly imported, dont scope for node_module
-  options.cssModulesOptions.generateScopedName = this.resourcePath.includes('node_modules') ? '[local]' : undefined;
-  return loadStyles({ path: this.resourcePath, ...options });
+  // Use the same implementation as the dev bundler for consistency
+  return loadStyles({ path: this.resourcePath, ...this.getOptions() });
 }
 
 export default stylesLoader;