Fix Kafka TLS configuration with plaintext authentication

This change fixes the Kafka TLS configuration to work correctly when using plaintext authentication with TLS enabled. Previously, TLS would only be configured when authentication=tls, breaking SASL-SSL with PLAIN authentication. Resolves jaegertracing#6744 Signed-off-by: Amol Verma <[email protected]>
amilbcahat · Feb 21, 2025 · 0bdd1a8 · 0bdd1a8
1 parent 2b355d0
commit 0bdd1a8
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/pkg/kafka/auth/config.go b/pkg/kafka/auth/config.go
@@ -76,7 +76,6 @@ func (config *AuthenticationConfig) InitFromViper(configPrefix string, v *viper.
 	config.Kerberos.KeyTabPath = v.GetString(configPrefix + kerberosPrefix + suffixKerberosKeyTab)
 	config.Kerberos.DisablePAFXFast = v.GetBool(configPrefix + kerberosPrefix + suffixKerberosDisablePAFXFAST)
 
-	tlsEnabled := v.GetBool(configPrefix + ".tls.enabled")
 	if config.Authentication == tls || v.GetBool(configPrefix+".tls.enabled") {
 		tlsClientConfig := tlscfg.ClientFlagsConfig{
 			Prefix: configPrefix,