Relax omniauth gem version requirements #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omniauth v2.0.0 was just released, so this allows it to be upgraded.
|
@amirmanji If you willing to give me rubygems access, I could push a new release with this. My colleague has also added AOL support (they're sharing the same server software... it's just another default configuration with the AOL URLs). |
* add AOL strategy
* rename YahooOAuth2
* note that the back compat doesn't work.
TODO: try OmniAuth::Configuration.add_camelization("oauth", "OAuth")
|
Updating the PR title to reflect AOL support. There are some documentation changes that still ought to be made. And backwards compatibility was probably broken: need to try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omniauth v2.0.0 was recently released, so this allows it to be upgraded. v2.0.0 finally fixes CVE-2015-9284 by default and without hacky workarounds, so I hope most apps will be upgrading ASAP.
This seems to be working just fine with the latest version (I haven't finished my testing yet, so I'll try to remember to update this PR in the next couple of days).