[pull] main from microsoft:main

[pull]

See Commits and Changes for more details.

---

Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

[restack-app]

No applications have been configured for previews targeting branch: main. To do so go to restack console and configure your applications for previews.

[commit-lint]

Features

• ui: show test status in trace view (feat(ui): show test status in trace view microsoft/playwright#27785) (0bb9f7c)
• firefox: roll to r1426 (feat(firefox): roll to r1426 microsoft/playwright#27794) (60f2de7)
• firefox-beta: roll to r1426 (feat(firefox-beta): roll to r1426 microsoft/playwright#27793) (1afeff5)
• chromium-tip-of-tree: roll to r1163 (feat(chromium-tip-of-tree): roll to r1163 microsoft/playwright#27817) (37ab683)
• expect: generate toHaveText (feat(expect): generate toHaveText microsoft/playwright#27824) (24deac4)
• chromium: roll to r1087 (feat(chromium): roll to r1087 microsoft/playwright#27834) (49b662c)
• support firefoxUserPrefs in launchPersistentContext (feat: support firefoxUserPrefs in launchPersistentContext microsoft/playwright#27840) (88f30d1)

Tests

• add test for multipart keeping order (test: add test for multipart keeping order microsoft/playwright#27787) (5f0d91a)

Documentation

• update screenshots (docs: update screenshots microsoft/playwright#27760) (09ff9a5)
• add Argos Reporter to doc (docs: add Argos Reporter to doc microsoft/playwright#27789) (ae1e188)
• add v1.39 release video (docs: add release video microsoft/playwright#27838) (d395a38)

Bug Fixes

• npx playwright install on Ubuntu 18.04 (fix: npx playwright install on Ubuntu 18.04 microsoft/playwright#27791) (5423512)
• ignoreCase in toHaveAttribute (fix: ignoreCase in toHaveAttribute microsoft/playwright#27809) (0ade5aa)
• html: do not update total time when filtering tests (fix(html): do not update total time when filtering tests microsoft/playwright#27808) (86c78c1)

Chore

• do not select after hooks automatically (chore: do not select after hooks automatically microsoft/playwright#27805) (47733b0)
• driver: roll driver to recent Node.js LTS version (chore(driver): roll driver to recent Node.js LTS version microsoft/playwright#27814) (00d3b4b)
• update Docker Node.js version to new LTS (20) (chore: update Docker Node.js version to new LTS (20) microsoft/playwright#27813) (841bb92)
• get rid of rimraf package (chore: get rid of rimraf package microsoft/playwright#27790) (5f36608)
• stream trace viewer logs (chore: stream trace viewer logs microsoft/playwright#27807) (778047f)
• render time in the trace viewer log (chore: render time in the trace viewer log microsoft/playwright#27825) (ff206bd)
• ct: resolve internal type errors (chore(ct): resolve internal type errors microsoft/playwright#26779) (54ebee7)
• refactor Recorder, introduce RecorderTool (chore: refactor Recorder, introduce RecorderTool microsoft/playwright#27826) (4d8dd55)
• render full pathname in network panel (chore: render full pathname in network panel microsoft/playwright#27843) (4d82d68)
• render sidebar tab selector as drop down (chore: render sidebar tab selector as drop down microsoft/playwright#27844) (462e70a)

Contributors

pavelfeldman, playwrightmachine, mxschmitt, debs-obrien, yury-s, gregberge, jsenin, sand4rt, dgozman

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

• @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
• @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
• @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
• @Commit-Lint merge disable will desactivate merge dependabot PR
• @Commit-Lint review will approve dependabot PR
• @Commit-Lint stop review will stop approve dependabot PR

[coderabbitai]

Important

Auto Review Skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai help to get help.
• @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

[pr-code-reviewer]

👋 Hi there!

1. Update the Chromium version badge to the latest version (e.g., 119.0.6045.59) to reflect the current version of Chromium being used.
2. Remove the Firefox and WebKit version badges if they are not relevant or outdated for the project.
3. Ensure that all the badge links are correct and up-to-date, directing users to the appropriate resources.

_{^{Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].}}

[instapr]

• Please remove the unnecessary line referencing future dates.
• Consider providing more specific details in the PR body instead of redirecting to commits and changes.
• Remove the sponsorship message from the PR body.

[sweep-ai]

Apply Sweep Rules to your PR?

• Apply: Leftover TODOs in the code should be handled.
• Apply: All new business logic should have corresponding unit tests in the tests/ directory.
• Apply: Any clearly inefficient or repeated code should be optimized or refactored.

[pr-explainer-bot]

Hey there! Looks like you need a Pull Request review markdown doc. Let's get started!

Changes ✔️

1. Added a new file testUtils.ts in the packages/trace-viewer/src/ui directory.
2. Added UITestStatus type with possible values: 'none', 'running', 'scheduled', 'passed', 'failed', 'skipped'.
3. Added testStatusIcon function that returns an icon based on the given UITestStatus.
4. Added testStatusText function that returns a text based on the given UITestStatus.

Suggestions 💡

In uiModeView.tsx:

• Line 38: Imported testStatusIcon function from ./testUtils.
• Line 38: Imported UITestStatus type from ./testUtils.
• Line 361: Changed the type of selectedItem from { testFile?: SourceLocation, testCase?: TestCase } to { treeItem?: TreeItem, testFile?: SourceLocation, testCase?: TestCase }.
• Line 517: Removed the icon mapping logic and replaced it with testStatusIcon function.
• Line 543: Removed the icon mapping logic and replaced it with testStatusIcon function.
• Line 795: Changed the type of status in TreeItem from 'none' | 'running' | 'scheduled' | 'passed' | 'failed' | 'skipped' to UITestStatus.

Bugs 🐛

Potential bugs:

• In testUtils.ts, the testStatusIcon function does not have a default case for the status parameter. It should handle the case when the status is not one of the defined values.
• In testUtils.ts, the testStatusText function does not have a default case for the status parameter. It should handle the case when the status is not one of the defined values.

Improvements 🚀

In uiModeView.tsx, the logic for mapping icons based on the status property can be refactored for better readability. Here's an improved version:

import { testStatusIcon } from './testUtils';
import type { UITestStatus } from './testUtils';

const TestList: React.FC<{
  // ...
  onItemSelected: (item: { treeItem?: TreeItem, testCase?: TestCase, testFile?: SourceLocation }) => void,
  // ...
}> = ({
  // ...
  onItemSelected,
  // ...
}) => {
  // ...
  const icon = (treeItem: TreeItem) => testStatusIcon(treeItem.status);
  // ...
  return (
    // ...
    <Tree
      // ...
      icon={icon}
      // ...
    />
    // ...
  );
};

Rating ⭐⭐⭐⭐⭐⭐⭐

I rate the code a 7 out of 10 based on readability, performance, and security.

That's it! Hope this helps with your Pull Request review. Let me know if you need anything else. Cheers!