Issues/0150 max inst count segfault (#151)

* add test for maxInstCount exception, improve exception message output

* increase maxInstCount to 100 million, fixes #150

.github/workflows/ubuntu_debug.yml

@@ -170,6 +170,8 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
+    - name: run apt-get update
+      run: sudo apt-get -y update
 
     - name: install test tool - valgrind
       run: sudo apt-get -y install valgrind
@@ -237,7 +239,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-
+    - name: run apt-get update
+      run: sudo apt-get -y update
+
     - name: install test tool - valgrind
       run: sudo apt-get -y install valgrind
 

.github/workflows/ubuntu_release.yml

@@ -256,6 +256,8 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
+    - name: run apt-get update
+      run: sudo apt-get -y update
 
     - name: install test tool - valgrind
       run: sudo apt-get -y install valgrind
@@ -306,7 +308,9 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-
+    - name: run apt-get update
+      run: sudo apt-get -y update
+
     - name: install test tool - valgrind
       run: sudo apt-get -y install valgrind
 

Dockerfile

@@ -32,6 +32,7 @@ RUN apt-get -y install libtiff-dev
 WORKDIR /usr/src/CTL
 COPY . .
 WORKDIR /usr/src/CTL/build
+RUN rm -R * || true
 RUN cmake ..
 RUN make
 RUN make install

Dockerfile_openexr3

@@ -47,6 +47,7 @@ RUN apt-get -y install libtiff-dev
 WORKDIR /usr/src/CTL
 COPY . .
 WORKDIR /usr/src/CTL/build
+RUN rm -R * || true
 RUN cmake ..
 RUN make
 RUN make install

lib/IlmCtlSimd/CtlSimdInterpreter.cpp

@@ -86,7 +86,7 @@ SimdInterpreter::SimdInterpreter():
     Interpreter(),
     _data (new Data)
 {
-    _data->maxInstCount = 10000000;
+    _data->maxInstCount = 100000000;
     _data->abortCount = 0;
 
     //

lib/IlmCtlSimd/CtlSimdXContext.cpp

@@ -240,7 +240,11 @@ SimdXContext::countInstruction ()
     if ((++_instCount & 0x01fff) == 0)
     {
 	if (_maxInstCount && _instCount > _maxInstCount)
-	    throw Ctl::MaxInstExc ("Maximum CTL instruction count exceeded.");
+      THROW(Ctl::MaxInstExc, "\nException Ctl::MaxInstExc thrown\n" <<
+        "Maximum CTL instruction count _maxInstCount=" << _maxInstCount <<
+        " exceeded, _instCount=" << _instCount << "\n" <<
+        "Try increasing SimdInterpreter::Data->maxInstCount\n");
+//	    throw Ctl::MaxInstExc ("Maximum CTL instruction count exceeded.");
 
 	if (_abortCount != _interpreter.abortCount())
 	    throw Ctl::AbortExc ("CTL program aborted.");

resources/test/ctl/throw_maxInstCount_exception.ctl

@@ -0,0 +1,21 @@
+const unsigned int loop_limit = UINT_MAX;
+
+void main
+    (input varying float rIn,
+     input varying float gIn,
+     input varying float bIn,
+     output varying float rOut,
+     output varying float gOut,
+     output varying float bOut
+     )
+{
+    unsigned int x = 0;
+    for( unsigned int i = 0; i < loop_limit; i = i + 1)
+    {
+        x = i;
+    }
+
+    rOut = x;
+	gOut = x;
+	bOut = x;
+}

unittest/ctlrender/CMakeLists.txt

@@ -126,3 +126,8 @@ if(OpenEXR_FOUND)
     add_test(NAME "ctlrender-invalid-output-filename-exr" COMMAND ctlrender -force -format exr -ctl "${TEST_FILES}/unity.ctl" "${TEST_FILES}/colorbars_nuke_rgb_exr16.exr" "${CTLRENDER_OUTPUT_FOLDER}/missing_folder/invalid_filename_out.exr")
     set_tests_properties("ctlrender-invalid-output-filename-exr" PROPERTIES WILL_FAIL TRUE)
 endif()
+
+# test for maxInstCount exception
+add_test(NAME "ctlrender-maxInstCount-exception" COMMAND ctlrender -force -ctl "${PROJECT_SOURCE_DIR}/resources/test/ctl/throw_maxInstCount_exception.ctl" "${PROJECT_SOURCE_DIR}/resources/test/exr/colorbars_nuke_rgb_exr16.exr" "${CTLRENDER_OUTPUT_FOLDER}/maxInstCount_exception.exr")
+set_tests_properties("ctlrender-maxInstCount-exception" PROPERTIES WILL_FAIL TRUE)
+