Disambiguate clamp
calls in exrToDpx.cpp
#164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++17 now has
std::clamp
1, so the calls toclamp
in this filecause the compiler to error with2
Both this code and
Imath::clamp
long predatestd::clamp
, so it seemsto me that
Imath::clamp
is what's intended here.This fixes a build failure at Homebrew while rebuilding CTL for OpenEXR
3.3.0.3
Footnotes
https://en.cppreference.com/w/cpp/algorithm/clamp ↩
Logs available at https://github.com/Homebrew/homebrew-core/actions/runs/11113893071/job/30879442929?pr=192399#step:3:375 ↩
See https://github.com/Homebrew/homebrew-core/pull/192399 ↩