Enhance invoice response validation logic

ampeco · Jan 6, 2025 · ecbc594 · ecbc594
1 parent 9c3a623
commit ecbc594
Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "ampeco/omnipay-cardcom",
     "description": "Omnipay plugin for Cardcom payment gateway",
-    "version": "1.3.3",
+    "version": "1.3.4",
     "type": "library",
     "license": "MIT",
     "autoload": {

diff --git a/src/CommonParameters.php b/src/CommonParameters.php
@@ -214,11 +214,6 @@ public function getSum()
         return $this->getParameter('sum');
     }
 
-
-
-
-
-    ///v2
     public function setInvoiceLines($value)
     {
         return $this->setParameter('invoice_lines', $value);

diff --git a/src/Message/FetchInvoiceResponse.php b/src/Message/FetchInvoiceResponse.php
@@ -12,7 +12,7 @@ public function __construct(AbstractRequest $request, $data, $statusCode)
 
     public function isSuccessful() : bool
     {
-        return $this->getCode() < 400 && in_array($this->data['ResponseCode'], [self::INVOICE_RESPONSE_CODE_SUCCESS]);
+        return $this->getCode() < 400 && $this->getDocumentUrl() !== null && $this->data['ResponseCode'] == self::INVOICE_RESPONSE_CODE_SUCCESS;
     }
 
     public function getDocumentUrl()

diff --git a/src/Message/IssueInvoiceResponse.php b/src/Message/IssueInvoiceResponse.php
@@ -12,7 +12,7 @@ public function __construct(AbstractRequest $request, $data, $statusCode)
 
     public function isSuccessful() : bool
     {
-        return $this->getCode() < 400 && $this->data['ResponseCode'] === self::INVOICE_RESPONSE_CODE_SUCCESS && $this->getInvoiceNumber() !== null;
+        return $this->getCode() < 400 && $this->data['ResponseCode'] === self::INVOICE_RESPONSE_CODE_SUCCESS && $this->getInvoiceNumber() !== null && $this->getDocumentUrl() !== null;
     }
 
     public function getInvoiceNumber()