Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-391 G&S roles and permissions #545

Merged
merged 3 commits into from
Mar 7, 2025
Merged

DOC-391 G&S roles and permissions #545

merged 3 commits into from
Mar 7, 2025

Conversation

markzegarelli
Copy link
Member

@markzegarelli markzegarelli requested a review from vayyala March 6, 2025 20:56
@vercel Vercel
Copy link

vercel bot commented Mar 6, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
amplitude-docs ✅ Ready (Inspect) Visit Preview Mar 7, 2025 5:27pm

@markzegarelli markzegarelli requested a review from tkainrad March 7, 2025 16:33
tkainrad
tkainrad approved these changes Mar 7, 2025
View reviewed changes
Copy link

@tkainrad tkainrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting us off the ground here!

I think we can follow up with some more details, like on how making unpublished theme changes works as a Member, and maybe extract to its own page. But you got the important parts exactly right.

@markzegarelli markzegarelli merged commit 6b80602 into main Mar 7, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkainrad tkainrad tkainrad approved these changes

@vayyala vayyala Awaiting requested review from vayyala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markzegarelli @tkainrad