fix: tests

amplitude · Aug 2, 2024 · 684a99f · 684a99f
1 parent 4a2d1c7
commit 684a99f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/main/kotlin/cohort/CohortApi.kt b/src/main/kotlin/cohort/CohortApi.kt
@@ -65,6 +65,10 @@ internal class DynamicCohortApi(
         return if (proxyUrl != null) {
             try {
                 getCohort(proxyUrl, cohortId, cohort)
+            } catch (e: CohortNotModifiedException) {
+                throw e
+            } catch (e: CohortTooLargeException) {
+                throw e
             } catch (e: Exception) {
                 metrics.onCohortDownloadOriginFallback(e)
                 getCohort(serverUrl, cohortId, cohort)

diff --git a/src/test/kotlin/cohort/CohortDownloadApiTest.kt b/src/test/kotlin/cohort/CohortDownloadApiTest.kt
@@ -20,8 +20,7 @@ class CohortDownloadApiTest {
     private val httpClient = OkHttpClient()
     private val server = MockWebServer()
     private val url = server.url("/")
-    private val proxyUrl = server.url("/")
-    private val api = DynamicCohortApi(apiKey,secretKey, maxCohortSize, url, proxyUrl, httpClient)
+    private val api = DynamicCohortApi(apiKey,secretKey, maxCohortSize, url, null, httpClient)
     @Test
     fun `cohort download, success`() {
         val response = cohortResponse("a", setOf("1"))