fix: use explicit nullable type for AmplitudeConfig (#32)

amplitude · Jan 14, 2025 · c5a91cd · c5a91cd
1 parent 63703e1
commit c5a91cd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-version: ['7.4', '8.0', '8.1', '8.2', '8.3']
+        php-version: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
         os: [ubuntu-latest]
     runs-on: ${{ matrix.os }}
 

diff --git a/src/Amplitude/Amplitude.php b/src/Amplitude/Amplitude.php
@@ -26,7 +26,7 @@ class Amplitude
     private LoggerInterface $logger;
     private AmplitudeConfig $config;
 
-    public function __construct(string $apiKey, AmplitudeConfig $config = null)
+    public function __construct(string $apiKey, ?AmplitudeConfig $config = null)
     {
         $this->apiKey = $apiKey;
         $this->config = $config ?? AmplitudeConfig::builder()->build();

diff --git a/tests/Amplitude/MockAmplitude.php b/tests/Amplitude/MockAmplitude.php
@@ -9,7 +9,7 @@
 
 class MockAmplitude extends Amplitude
 {
-    public function __construct(string $apiKey, AmplitudeConfig $config = null)
+    public function __construct(string $apiKey, ?AmplitudeConfig $config = null)
     {
         parent::__construct($apiKey, $config);
     }