-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Updated Neodata configuration to include GDPR in pageview and added new cookiematching #40245
✨ Updated Neodata configuration to include GDPR in pageview and added new cookiematching #40245
Conversation
Hi, Please sign the CLA. Also please fix the test failures. |
@powerivq Thank you for your kind reply. I have signed the CLA and successfully fixed the test failures related to our Neodata configuration. However, the test is now failing during the "installing Firefox" step. It returns a 404 error when attempting to install Firefox, which makes me think it might be trying to fetch an outdated version. Unfortunately, I have no idea where the installation script is located or how to modify it. Could you please provide some support or guidance on how to resolve this issue? I’d really appreciate any help to get this test passing. Thanks in advance! |
@RosadiniGianluca We are aware of this and working on it. |
@RosadiniGianluca Please rebase against the latest main branch. The fix is in. |
…AMATH cookie matching 1. Added GDPR Consent to Pageview 2. Added ADFORM Cookie Matching 3. Added MEDIAMATH Cookie Matching
14846db
to
c8f1da4
Compare
Hi @powerivq and team, First of all, thank you for approving and merging my changes! I really appreciate your support. I have successfully cleared my browser cache and tested in incognito mode, but I still see the old configuration being fetched from neodata.json in the network requests. This suggests that the issue might be due to caching on your side or a deploy that hasn't been completed yet. Could you please check if the latest configuration has been properly deployed and is being served correctly? Let me know if you need any further details from my side. Thanks again for your help! Best, |
@RosadiniGianluca This is expected. Release to stable will take roughly two weeks. https://github.com/ampproject/amphtml/blob/main/docs/release-schedule.md |
We need to update the Neodata vendor configuration with these new features:
Thank you for you cooperation.