Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close and destroy sockets on connection error. #514

Closed

Conversation

rumata28
Copy link

@rumata28 rumata28 commented May 2, 2019

Add sock.end and sock.destroy calls for sock.once('error', ...)
event handler and for c.open(fields, ...) callback - just like it was
done for connection timeout callback.

Resolves #513

Add `sock.end` and `sock.destroy` calls for `sock.once('error', ...)`
event handler and for `c.open(fields, ...)` callback - just like it was
done for connection timeout callback.

Resolves amqp-node#513
@rumata28
Copy link
Author

rumata28 commented May 2, 2019

Sorry, tests failed.
I use Windows as a development machine, need to figure it out how to install everything.
Just checked that the change fixes issue for my tests, locally.

@rumata28
Copy link
Author

rumata28 commented May 2, 2019

Close it, will reopen once I make it work.

@rumata28 rumata28 closed this May 2, 2019
@rumata28 rumata28 deleted the connect_close_sock_on_failure branch May 2, 2019 11:59
@rumata28 rumata28 restored the connect_close_sock_on_failure branch May 2, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed "connect" call does not close socket
1 participant