added support for 'U' and 'u' to codec #620
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi ... |
Merged
11 tasks
|
@cressie176 Do you think we should merge this? See #646 on same topic, except in this case it's clear how unsupported data was created. |
Sorry, didn't properly understand this before. Yes, I think so - if amqplib clients are going to have to consume stuff published by other libraries with different type keys |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble decoding a number (unsigned 16 bit integer) created by a python client (https://github.com/pika/pika) and consumed by this client. I found out that there is no implementation for 'u'.
Let me know if i am missing something, i am not so familiar with nodejs and doing pullrequests ;).