Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: Increased pytest and related packages version in search service #1162

Closed

Conversation

jsnowacki
Copy link
Contributor

Summary of Changes

Pytest version increase as it was a couple of major versions behind and works fine with the new one without any changes.

Tests

Run standard pytest.

Documentation

It was substantially behind the current version

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does

@jsnowacki jsnowacki requested a review from a team as a code owner May 27, 2021 15:46
@boring-cyborg boring-cyborg bot added the area:search From the search folder label May 27, 2021
@mgorsk1
Copy link
Contributor

mgorsk1 commented May 27, 2021

there is refactor underway which would take care of it: #1163 do you think it's ok to wait for it?

@jsnowacki
Copy link
Contributor Author

@mgorsk1 Yes, I just followed up the recent changes 'cause I forgot about it really. If it's coming, it's fine, I don't need it right away.

@mgorsk1 mgorsk1 closed this May 28, 2021
@jsnowacki jsnowacki deleted the feat/search_pytest_version_up branch May 28, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:search From the search folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants