refactor: undo the great unpinning

[dkunitsk]

Signed-off-by: Dmitriy Kunitskiy [email protected]

Summary of Changes

This formally ends The Great Unpinning. In effect, I realized it does not solve the problem of amundsen-common as it still results in this simple library requiring many unrelated dependencies. Additionally, the loss of reproducible builds introduced by unpinned service dependencies is possibly not worth the benefit.

Instead, I propose to keep amundsen-common separate with its small requirements set. Why is this okay? Because, when amundsen-common is used inside databuilder/frontend/metadata/search, the install_requires of amundsen-common will be completely irrelevant. In other words, the pain of desynchronized dependencies will not return and the benefits of @mgorsk1's efforts in #1163 are maintained.

One element of the earlier PR I have kept is the removal of outdated dependencies:

• itsdangerous
• six
• MarkupSafe
• aniso8601

Tests

Documentation

CheckList

Make sure you have checked all steps below to ensure a timely review.

• PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.
• PR includes a summary of changes.
• PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does

[dkunitsk]

note, I didn't author this comment, I took it from the earlier version of amundsen-common

[allisonsuarez]

My understanding is there's enough consensus on this route to try it out. we can always go back if not, but I think this is the safest way out of the situation.