fixed where #2216
Closed
fixed where #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing where clause problem in redshift_metadata_extractor.py
|
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md) |
| @@ -29,7 +29,7 @@ def get_sql_statement(self, use_catalog_as_cluster_name: bool, where_clause_suff | |||
| cluster_source = f"'{self._cluster}'" | |||
|
|
|||
| if where_clause_suffix: | |||
| if where_clause_suffix.lower().startswith("where"): | |||
| if "where" in where_clause_suffix.lower(): | |||
There was a problem hiding this comment.
is this change in case there is leading whitespace? I'd recommend instead using lstrip() if so, and then you can still check that the string starts with where
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
This looks like a duplicate of #2217. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing where clause problem in redshift_metadata_extractor.py
Description
Motivation and Context
How Has This Been Tested?
Documentation
CheckList